On Fri, Jun 17, 2016 at 08:32:10PM +1000, Michael Ellerman wrote:
>On Fri, 2016-20-05 at 06:41:41 UTC, Gavin Shan wrote:
>> diff --git a/arch/powerpc/include/asm/opal-api.h
>> b/arch/powerpc/include/asm/opal-api.h
>> index 9bb8ddf..2417c86 100644
>> --- a/arch/powerpc/include/asm/opal-api.h
>> +++ b/arch/powerpc/include/asm/opal-api.h
>> @@ -344,6 +348,18 @@ enum OpalPciResetState {
>> OPAL_ASSERT_RESET = 1
>> };
>>
>> +enum OpalPciSlotPresentenceState {
>
>In skiboot this is called "OpalPciSlotPresence".
>
>I've renamed it.
>
>> + OPAL_PCI_SLOT_EMPTY = 0,
>> + OPAL_PCI_SLOT_PRESENT = 1
>> +};
>> +
>> +enum OpalPciSlotPowerState {
>
>In skiboot this is called "OpalPciSlotPower".
>
>I've renamed it.
>
>> + OPAL_PCI_SLOT_POWER_OFF = 0,
>> + OPAL_PCI_SLOT_POWER_ON = 1,
>> + OPAL_PCI_SLOT_OFFLINE = 2,
>> + OPAL_PCI_SLOT_ONLINE = 3
>> +};
>> +
>> enum OpalSlotLedType {
>> OPAL_SLOT_LED_TYPE_ID = 0, /* IDENTIFY LED */
>> OPAL_SLOT_LED_TYPE_FAULT = 1, /* FAULT LED */
>> @@ -378,6 +394,7 @@ enum opal_msg_type {
>> OPAL_MSG_DPO = 5,
>> OPAL_MSG_PRD = 6,
>> OPAL_MSG_OCC = 7,
>> + OPAL_MSG_PCI_HOTPLUG = 8,
>
>I don't see this in skiboot?
>
>It also doesn't seem to be used, so I've dropped it.
>
Thanks, Michael. All the changes are correct. The enum name was changed
in the last skiboot patchset that was merged couple days ago. At same
time, OPAL_MSG_PCI_HOTPLUG isn't needed as PCI hotplug won't have one
dedicated message type, an asychornous message is used instead.
Thanks,
Gavin
>> OPAL_MSG_TYPE_MAX,
>> };
>>
>
>cheers
>
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
