Michael Neuling <mi...@neuling.org> writes: > Aneesh, > > I'm not sure why we need this patch. > > It seems to be moving the initialisation of some global variables into > init functions from the definitions. And renames some things.
because the value to which it is getting initialized is no more a constant. > >> diff --git a/arch/powerpc/kernel/pci_64.c b/arch/powerpc/kernel/pci_64.c >> index 41503d7d53a1..3759df52bd67 100644 >> --- a/arch/powerpc/kernel/pci_64.c >> +++ b/arch/powerpc/kernel/pci_64.c >> @@ -38,7 +38,7 @@ >> * ISA drivers use hard coded offsets. If no ISA bus exists nothing >> * is mapped on the first 64K of IO space >> */ >> -unsigned long pci_io_base = ISA_IO_BASE; >> +unsigned long pci_io_base; >> EXPORT_SYMBOL(pci_io_base); >> >> static int __init pcibios_init(void) >> @@ -47,6 +47,7 @@ static int __init pcibios_init(void) >> >> printk(KERN_INFO "PCI: Probing PCI hardware\n"); >> >> + pci_io_base = ISA_IO_BASE; > > Did you mean to change this in this patch? This seems to be a random > change in pci code. > ISA_IO_BASE is not a constant now. -aneesh _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev