On 15-04-16, 11:58, Akshay Adiga wrote:
> static int powernv_cpufreq_reboot_notifier(struct notifier_block *nb,
> - unsigned long action, void *unused)
> + unsigned long action, void *unused)
Unrelated change.. better don't add such changes..
> {
> int cpu;
> struct cpufreq_policy cpu_policy;
> @@ -603,15 +843,18 @@ static struct notifier_block powernv_cpufreq_opal_nb = {
> static void powernv_cpufreq_stop_cpu(struct cpufreq_policy *policy)
> {
> struct powernv_smp_call_data freq_data;
> -
> + struct global_pstate_info *gpstates = policy->driver_data;
You removed a blank line here and I feel the code looks better with
that.
> freq_data.pstate_id = powernv_pstate_info.min;
> + freq_data.gpstate_id = powernv_pstate_info.min;
> smp_call_function_single(policy->cpu, set_pstate, &freq_data, 1);
> + del_timer_sync(&gpstates->timer);
> }
>
> static struct cpufreq_driver powernv_cpufreq_driver = {
> .name = "powernv-cpufreq",
> .flags = CPUFREQ_CONST_LOOPS,
> .init = powernv_cpufreq_cpu_init,
> + .exit = powernv_cpufreq_cpu_exit,
> .verify = cpufreq_generic_frequency_table_verify,
> .target_index = powernv_cpufreq_target_index,
> .get = powernv_cpufreq_get,
None of the above comments are mandatory for you to fix..
Acked-by: Viresh Kumar <viresh.ku...@linaro.org>
--
viresh
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
