Hi Mikey,
Le 15/03/2016 01:27, Michael Neuling a écrit :
I'm not happy with doing this unless we add something which advertises
that it's synced or not to userspace.
If we do that, I'm happy to just fail without the need of the parameter
but advertise it to userspace.
OK, so I'm guessing that by advertising, you mean more than logging
something in dmesg, since that's already the case.
Are you suggesting to make the sync status available programmatically
(like through a status on /sys)? Seems like it would be pushing some
work on applications which want to use the psl timebase in the future,
just because there's currently a problem with some card models.
So I doubt I'm understanding you correctly here.
My vote was to keep it simple: it's all or nothing. If the driver claims
to support psl timebase sync, it should work on all the cards. This is
not the case today, so let's not make it a requirement until we are
confident it's working as expected. cxlflash is not using it, so there
should be no harm done. We'd keep the psl sync code in mostly to get
exposure on multiple setups.
The parameter is a bit of a PITA too, as it's a driver level config not
card level. You really want to turn it on/off based on the card, not
the whole system.
I don't really care about the module parameter. It was mostly a feeble
attempt to be developer-friendly and activate the feature easily on some
setup.
Fred
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
