On Wed, Mar 09, 2016 at 05:28:59PM +1100, Alexey Kardashevskiy wrote: > This replaces magic constants for TCE Kill IODA2 register with macros. > > Signed-off-by: Alexey Kardashevskiy <a...@ozlabs.ru>
Reviewed-by: David Gibson <da...@gibson.dropbear.id.au>
> ---
> arch/powerpc/platforms/powernv/pci-ioda.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/platforms/powernv/pci-ioda.c
> b/arch/powerpc/platforms/powernv/pci-ioda.c
> index 889eca3..33e9489 100644
> --- a/arch/powerpc/platforms/powernv/pci-ioda.c
> +++ b/arch/powerpc/platforms/powernv/pci-ioda.c
> @@ -1824,10 +1824,13 @@ static struct iommu_table_ops pnv_ioda1_iommu_ops = {
> .get = pnv_tce_get,
> };
>
> +#define TCE_KILL_INVAL_PE PPC_BIT(1)
> +#define TCE_KILL_INVAL_TCE PPC_BIT(2)
> +
> static inline void pnv_pci_ioda2_tce_invalidate_pe(struct pnv_ioda_pe *pe)
> {
> /* 01xb - invalidate TCEs that match the specified PE# */
> - unsigned long val = (0x4ull << 60) | (pe->pe_number & 0xFF);
> + unsigned long val = TCE_KILL_INVAL_PE | (pe->pe_number & 0xFF);
> struct pnv_phb *phb = pe->phb;
> struct pnv_ioda_pe *npe;
> int i;
> @@ -1855,7 +1858,7 @@ static void pnv_pci_ioda2_do_tce_invalidate(unsigned
> pe_number, bool rm,
> unsigned long start, end, inc;
>
> /* We'll invalidate DMA address in PE scope */
> - start = 0x2ull << 60;
> + start = TCE_KILL_INVAL_TCE;
> start |= (pe_number & 0xFF);
> end = start;
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev
