On Wed, Dec 12, 2007 at 04:54:29PM -0600, Scott Wood wrote:
> This board is also resold by Freescale under the names
> "QUICCStart MPC8248 Evaluation System" and "CWH-PPC-8248N-VE".

[snip]
> +     localbus {

Should be [EMAIL PROTECTED]

> +             compatible = "fsl,ep8248e-localbus",
> +                          "fsl,mpc8248-localbus",
> +                          "fsl,pq2-localbus";
> +             #address-cells = <2>;
> +             #size-cells = <1>;
> +             reg = <f0010100 40>;
> +
> +             ranges = <0 0 fc000000 04000000
> +                       1 0 fa000000 00008000>;
> +
> +             [EMAIL PROTECTED],3800000 {
> +                     compatible = "cfi-flash";
> +                     reg = <0 3800000 800000>;
> +                     bank-width = <4>;
> +                     device-width = <2>;
> +             };
> +
> +             [EMAIL PROTECTED],0 {
> +                     #address-cells = <2>;
> +                     #size-cells = <1>;
> +                     reg = <1 0 10>;
> +                     compatible = "fsl,ep8248e-bcsr";
> +                     ranges;
> +
> +                     mdio {

As I think I said about another tree, this mdio-under-bcsr arrangement
is pretty strange.  What's going on here.


> +                             device_type = "mdio";
> +                             compatible = "fsl,ep8248e-mdio-bitbang";
> +                             #address-cells = <1>;
> +                             #size-cells = <0>;
> +                             reg = <1 8 1>;
> +
> +                             PHY0: [EMAIL PROTECTED] {
> +                                     interrupt-parent = <&PIC>;
> +                                     reg = <0>;
> +                                     device_type = "ethernet-phy";
> +                             };
> +
> +                             PHY1: [EMAIL PROTECTED] {
> +                                     interrupt-parent = <&PIC>;
> +                                     reg = <1>;
> +                                     device_type = "ethernet-phy";
> +                             };
> +                     };
> +             };
> +     };
> +
> +     memory {
> +             device_type = "memory";
> +             reg = <0 0>;
> +     };
> +
> +     [EMAIL PROTECTED] {
> +             #address-cells = <1>;
> +             #size-cells = <1>;
> +             device_type = "soc";

Ditch the device_type.

-- 
David Gibson                    | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au  | minimalist, thank you.  NOT _the_ _other_
                                | _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to