On Dec 6, 2007, at 8:01 PM, David Gibson wrote:
> On Wed, Dec 05, 2007 at 06:37:53PM +0800, Li Yang wrote:
>> Signed-off-by: Li Yang <[EMAIL PROTECTED]>
>> ---
>> Update SATA nodes; remove serdes nodes; add aliases and labels.
>>
>> arch/powerpc/boot/dts/mpc8377_mds.dts | 270 +++++++++++++++++++++++
>> ++++++++
>> arch/powerpc/boot/dts/mpc8378_mds.dts | 256 +++++++++++++++++++++++
>> ++++++
>> arch/powerpc/boot/dts/mpc8379_mds.dts | 284 +++++++++++++++++++++++
>> ++++++++++
>> 3 files changed, 810 insertions(+), 0 deletions(-)
>> create mode 100644 arch/powerpc/boot/dts/mpc8377_mds.dts
>> create mode 100644 arch/powerpc/boot/dts/mpc8378_mds.dts
>> create mode 100644 arch/powerpc/boot/dts/mpc8379_mds.dts
>>
>> diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts b/arch/powerpc/
>> boot/dts/mpc8377_mds.dts
>> new file mode 100644
>> index 0000000..919ffd0
>> --- /dev/null
>> +++ b/arch/powerpc/boot/dts/mpc8377_mds.dts
> [snip]
>> + aliases {
>> + ethernet0 = "/[EMAIL PROTECTED]/[EMAIL PROTECTED]";
>> + ethernet1 = "/[EMAIL PROTECTED]/[EMAIL PROTECTED]";
>> + serial0 = "/[EMAIL PROTECTED]/[EMAIL PROTECTED]";
>> + serial1 = "/[EMAIL PROTECTED]/[EMAIL PROTECTED]";
>> + pci0 = "/[EMAIL PROTECTED]";
>
> You can use path references for these now.
>
>> + };
>> +
>> + cpus {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + PowerPC,[EMAIL PROTECTED] {
>
> This should absolutely not have a "x" in it. Either have an exact
> model, or just use "[EMAIL PROTECTED]" (in which case you can put the model in
> "compatible").
>
> [snip]
>> + [EMAIL PROTECTED] {
>> + device_type = "i2c";
>
> Drop the device_type. No "i2c" device_type class is defined.
>
> [snip]
>> + /* phy type (ULPI, UTMI, UTMI_WIDE, SERIAL) */
>> + [EMAIL PROTECTED] {
>> + device_type = "usb";
>
> Drop device_type here too.
>
>> + compatible = "fsl-usb2-dr";
>> + reg = <23000 1000>;
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + interrupt-parent = < &ipic >;
>> + interrupts = <26 8>;
>> + phy_type = "utmi_wide";
>> + };
>> +
>> + [EMAIL PROTECTED] {
>> + device_type = "mdio";
>> + compatible = "gianfar";
>
> Grr... not your fault, but this crap in the gianfar driver where it
> uses the same compatible property for the mdio and MAC has to be
> fixed.
I've fixed this now. Look at my tree/patch.
> [snip]
>
>> + serial1:[EMAIL PROTECTED] {
>
> Standard style puts a space after the colon.
>
>> + device_type = "serial";
>> + compatible = "ns16550";
>> + reg = <4600 100>;
>> + clock-frequency = <0>;
>> + interrupts = <a 8>;
>> + interrupt-parent = < &ipic >;
>> + };
>> +
>> + [EMAIL PROTECTED] {
>> + model = "SEC3";
>> + compatible = "talitos";
>
> This driver, also, needs fixing to recognize a better formatted
> compatible property.
Can you respin with David's changes as well as mirror my cleanup of
the other 83xx/85xx .dts
- k
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
