On 12/10/07, Kumar Gala <[EMAIL PROTECTED]> wrote: > > On Dec 9, 2007, at 5:36 PM, Jon Smirl wrote: > > > Convert MPC i2c driver from being a platform_driver to an open > > firmware version. Error returns were improved. Routine names were > > changed from fsl_ to mpc_ to make them match the file name. > > > > Signed-off-by: Jon Smirl <[EMAIL PROTECTED]> > > --- > > > > arch/powerpc/sysdev/fsl_soc.c | 96 --------------------- > > drivers/i2c/busses/i2c-mpc.c | 190 +++++++++++++++++++++++++++ > > +------------- > > 2 files changed, 129 insertions(+), 157 deletions(-) > > this patch breaks arch/ppc users which are platform_driver based and > I'm guessing a number of arch/powerpc users which don't > of_platform_bus_probe().
We should just make two copies of the driver. All of this is needed to allow automatic loading of the correct i2c modules as dictated by the device tree. I'm working on the same support for automatically loading audio codec drivers. > Also, you should split out the conversion and error fixing into > separate patches. I can spin another revision to move those nine lines adding missing error returns to another patch. > > - k > -- Jon Smirl [EMAIL PROTECTED] _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
