On Thu, Dec 06, 2007 at 02:22:27PM +1100, Benjamin Herrenschmidt wrote: > > On Wed, 2007-12-05 at 17:40 +1100, Benjamin Herrenschmidt wrote: > > The current pci_assign_unassigned_resources() code doesn't work properly > > on 32 bits platforms with 64 bits resources. The main reason is the use > > of unsigned long in various places instead of resource_size_t. > > > > This fixes it, along with some tricks to avoid casting to 64 bits on > > platforms that don't need it in every printk around. > > > > This is a pre-requisite for making powerpc use the generic code instead of > > its own half-useful implementation. > > > > Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]> > > --- > > > > This version fixes some stupid warnings when using 32 bits resources > > ... and has warnings on 64 bits platforms... GRRRR > > This whole issue of printk vs. resource_size_t is a terrible mess :-( > > Part of the problem is that resource_size_t can be either u32 or u64.. > > that is it can be either unsigned int, unsigned long or unsigned long > long... and we have no way to reliably printk that.
We do this already just fine. Take a look in the kernel, I think we just always cast it to long long to be uniform. > Any clever idea before I start pushing filthy macros up linux/types.h ? I don't think any macros are needed. thanks, greg k-h _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
