On Wed, Dec 05, 2007 at 10:10:31PM +1100, Michael Ellerman wrote: > On Wed, 2007-12-05 at 01:30 -0800, Greg KH wrote: > > In doing a massive kobject cleanup of the kernel tree, I ran across the > > iseries_veth.c driver. > > > > It looks like the driver is creating a number of subdirectories under > > the driver sysfs directory. This is odd and probably wrong. You want > > these virtual connections to show up in the main sysfs device tree, not > > under the driver directory. > > > > I'll be glad to totally guess and try to move it around in the sysfs > > tree, but odds are I'll get it all wrong as I can't really test this > > out :) > > > > Any hints on what this driver is trying to do in this sysfs directories? > > I wrote the code, I think, but it's been a while - I'll have a look at > it tomorrow.
Yes, can you send me the sysfs tree output of the driver directory, and what exactly the different files in there are supposed to be used for? > Why is it "odd and probably wrong" to create subdirectories under the > driver in sysfs? Because a driver does not have "devices" under it in the sysfs tree. All devices liven in the /sys/devices/ tree so we can properly manage them that way. A driver will then bind to a device, and the driver core will set up the linkages in sysfs properly so that everthing looks uniform. By creating subdirectories associated with a driver, this breaks the model that the entire rest of the kernel is using, which is something that you really don't want to be doing :) How about describing what you were trying to achieve with these directories and files? thanks, greg k-h _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
