On Sun, Nov 04, 2007 at 12:53:17AM +0100, Marian Balakowicz wrote:
> Add device tree source file for Motion-PRO board.
>
> Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED]>
Same comments as for the other two device trees, plus those below:
[snip]
> + [EMAIL PROTECTED] { // Motion-PRO status LED
> + compatible = "promess,motionpro-statusled";
> + cell-index = <6>;
> + reg = <660 10>;
> + interrupts = <1 f 0>;
> + interrupt-parent = <&mpc5200_pic>;
> + blink-delay = <64>; // 100 msec
> + };
> +
> + [EMAIL PROTECTED] { // Motion-PRO ready LED
> + compatible = "promess,motionpro-readyled";
> + cell-index = <7>;
These cell-index values for the LEDs look very strange. How are they
used?
> + reg = <670 10>;
> + interrupts = <1 10 0>;
> + interrupt-parent = <&mpc5200_pic>;
> + };
> +
> + [EMAIL PROTECTED] { // Real time clock
> + compatible = "mpc5200b-rtc","mpc5200-rtc";
> + device_type = "rtc";
> + reg = <800 100>;
> + interrupts = <1 5 0 1 6 0>;
> + interrupt-parent = <&mpc5200_pic>;
> + };
> +
> + [EMAIL PROTECTED] {
> + compatible = "mpc5200b-mscan","mpc5200-mscan";
> + cell-index = <1>;
As for serial and gpt, is cell-index really suitable here?
> + interrupts = <2 12 0>;
> + interrupt-parent = <&mpc5200_pic>;
> + reg = <980 80>;
> + };
[snip]
> + [EMAIL PROTECTED] {
> + device_type = "spi";
> + compatible = "mpc5200b-spi","mpc5200-spi";
> + reg = <f00 20>;
> + interrupts = <2 d 0 2 e 0>;
> + interrupt-parent = <&mpc5200_pic>;
> + };
[snip]
> + // PSC2 in spi master mode
> + [EMAIL PROTECTED] { // PSC2
> + device_type = "spi";
> + compatible = "mpc5200b-psc-spi","mpc5200-psc-spi";
> + cell-index = <1>;
cell-index present for one spi, but not the other makes be even more
suspicious about it's applicability here...
> + reg = <2200 100>;
> + interrupts = <2 2 0>;
> + interrupt-parent = <&mpc5200_pic>;
> + };
[snip]
> + lpb {
> + model = "fsl,lpb";
> + compatible = "fsl,lpb";
Is lpb another one of these chipselect/offset configurable bus bridge
things? If so, you should use a 2-cell addressing convention for the
subnodes like fsl localbus and 4xx EBC.
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <50000000 50000000 00030000
> + ff000000 ff000000 01000000>;
> +
> + // 8-bit DualPort SRAM on LocalPlus Bus CS1
> + [EMAIL PROTECTED] {
> + compatible = "promess,motionpro-kollmorgen";
> + reg = <50000000 ffff>;
> + interrupts = <1 1 0>;
> + interrupt-parent = <&mpc5200_pic>;
> + };
> +
> + // 8-bit board CPLD on LocalPlus Bus CS2
> + [EMAIL PROTECTED] {
> + compatible = "promess,motionpro-cpld";
> + reg = <50010000 ffff>;
> + };
> +
> + // 8-bit custom Anybus Module on LocalPlus Bus CS3
> + anybus50020000 {
Missing '@'.
> + compatible = "promess,motionpro-anybus";
> + reg = <50020000 ffff>;
> + };
> + [EMAIL PROTECTED] {
> + compatible = "promess,pro_module_general";
> + reg = <50020000 3>;
> + };
> + [EMAIL PROTECTED] {
> + compatible = "promess,pro_module_dio";
> + reg = <50020800 2>;
> + };
> + };
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
