David Gibson wrote:
> On Wed, Oct 24, 2007 at 01:13:33AM +0200, Marian Balakowicz wrote:
>
> [snip]
>> + [EMAIL PROTECTED] {
>> + model = "fsl,lpb";
>> + compatible = "lpb";
>
> Not nearly specific enough. Must include a vendor prefix at least,
> and should have a lot more revision information. You should always be
> able to pick the right driver with compatible alone, "model" should
> generally be for human consumption, the driver shouldn't need it.
>
>> + device_type = "lpb";
>
> Drop this. Again, presence of a device_type property is the
> exception, not the rule.
>
>> + ranges = <0 fc000000 02000000>;
>
> You need #address-cells and #size-cells properties, too.
>
> [snip]
OK, will update that. I guess I'll also need to use 'compatible' and
skip type when passing bus ids to of_platform_bus_probe().
m.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
