On 10/24/07, Tjernlund <[EMAIL PROTECTED]> wrote: > While browsing the i2c-mpc.c driver I noticed some things that look odd > to me so I figured I report them. Could not find a maintainer in the > MAINTANERS file > so I sent here, cc:ed linuxppc-dev as well.
There appear to be more issues with this driver. It is still registering as platform driver instead of a of_platform driver. On the mpc5200 the probe function for platform drivers is not getting called, so fsl_i2c_probe never gets called. It's not clear to me that this driver is functioning on the mpc5200. > 1) There are a lot of return -1 error code that is propagated back to > userspace. Should be changed to proper -Exxx codes. > > 2) mpc_read(), according to the comment below it sends a STOP condition here > but > this function does not known if this is the last read or not. mpc_xfer is > the one that knows when the transaction is over and should send the stop, > which it already > does. > > /* Generate stop on last byte */ > if (i == length - 1) > writeccr(i2c, CCR_MIEN | CCR_MEN | CCR_TXAK); > > Jocke > > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@ozlabs.org > https://ozlabs.org/mailman/listinfo/linuxppc-dev > -- Jon Smirl [EMAIL PROTECTED] _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
