Dale Farnsworth wrote: > On Wed, Oct 24, 2007 at 03:19:14PM +0400, Valentine Barshak wrote: >> Dale Farnsworth wrote: >>> Valentine wrote: >>>> Actually I also don't see much reason for the >>>> USB_OHCI_HCD_PPC_OF_BE/USB_OHCI_HCD_PPC_OF_LE stuff. >>>> Is this really needed? >>> I think so. The SOC host controllers are BE and the PCI >>> host controllers are LE. Or, do you have an alternative >>> method of handling both types? >> Yes, PCI controllers are LE, but do we really need user-selectable >> USB_OHCI_HCD_PPC_OF_LE option, since USB_OHCI_LITTLE_ENDIAN is selected >> by default for USB_OHCI_HCD_PCI? >> The USB_OHCI_HCD_PPC_OF_LE/BE stuff is related to PPC OF glue only. >> I think it's useless. We should always enable >> USB_OHCI_BIG_ENDIAN_DESC and USB_OHCI_BIG_ENDIAN_MMIO for PPC OF >> and the real LE/BE implementation should be selected by the >> corresponding properties in the device tree. > > I agree that they don't need to be user selectable. It is far preferable > to deduce their values from existing information, if possible. > > -Dale
This is the original thread: http://ozlabs.org/pipermail/linuxppc-embedded/2006-November/025054.html I think the USB_OHCI_HCD_PPC_OF_LE/BE should be removed. We can't avoid the slight overhead even using these options, since USB_OHCI_BIG_ENDIAN_MMIO/DESC should always be anabled for PPC OF and we we still enable USB_OHCI_LITTLE_ENDIAN for USB_OHCI_HCD_PCI even if USB_OHCI_HCD_PPC_OF_LE is not set. Thanks, Valentine. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
