On Tue, 2007-10-23 at 16:34 -0500, Scott Wood wrote:
> Josh Boyer wrote:
> >> +#ifdef CONFIG_SUSPEND
> >> +void generic_suspend_disable_irqs(void)
> >> +{
> >> + preempt_disable();
> >> +
> >> + /* Disable the decrementer, so that it doesn't interfere
> >> + * with suspending.
> >> + */
> >> +
> >> + set_dec(0x7fffffff);
> >> + hard_irq_disable();
> >> + set_dec(0x7fffffff);
> >> +}
> >> +
> >> +void generic_suspend_enable_irqs(void)
> >> +{
> >> + wakeup_decrementer();
> >> +
> >> + local_irq_enable();
> >> + preempt_enable();
> >> +}
> >
> > Should these be static functions? Seems so...
>
> I was asked to make them available to be called by non-generic
> implementations.
Perhaps it's just me, but the names seem a bit _too_ generic if they
aren't going to be static functions. Maybe I'm paranoid.
josh
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
