> -----Original Message----- > From: David Gibson [mailto:[EMAIL PROTECTED] > Sent: Friday, October 19, 2007 8:56 AM > To: Li Yang-r58472 > Cc: [EMAIL PROTECTED]; [EMAIL PROTECTED]; > linuxppc-dev@ozlabs.org > Subject: Re: [PATCH v5 9/9] add MPC837x MDS board default device tree > > On Thu, Oct 18, 2007 at 06:16:20PM +0800, Li Yang wrote: > > Signed-off-by: Li Yang <[EMAIL PROTECTED]> > > --- > > diff --git a/arch/powerpc/boot/dts/mpc8377_mds.dts > > b/arch/powerpc/boot/dts/mpc8377_mds.dts > > new file mode 100644 > > index 0000000..8530de6 > > --- /dev/null > > +++ b/arch/powerpc/boot/dts/mpc8377_mds.dts > > @@ -0,0 +1,282 @@ > [snip] > > + [EMAIL PROTECTED] { > > + model = "SEC3"; > > + compatible = "talitos"; > > That compatible doesn't look specific enough. It should at > least have a vendor portion. In general it's best to have > all the information you need to pick a driver and options in > compatible, rather than splitting that info into model.
I think we could do this in a separate patch. Change the spec and then update all the in-tree device tree with SEC node. - Leo _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
