On 10/18/07, Wolfgang Grandegger <[EMAIL PROTECTED]> wrote:
> Hello,
>
> I see one more issue.
>
> Marian Balakowicz wrote:
> > Add device tree source file for Motion-PRO board.
> >
> > Signed-off-by: Marian Balakowicz <[EMAIL PROTECTED]>
> > ---
> [deletions]
> > + [EMAIL PROTECTED] {
> > + compatible = "mpc5200b-gpio\0mpc5200-gpio";
> > + reg = <b00 40>;
> > + interrupts = <1 7 0>;
> > + interrupt-parent = <&mpc5200_pic>;
> > + };
>
> Do we not need the field "device_type = "gpio" here?
>
> > + [EMAIL PROTECTED] {
> > + compatible = "mpc5200b-gpio-wkup\0mpc5200-gpio-wkup";
> > + reg = <c00 40>;
> > + interrupts = <1 8 0 0 3 0>;
> > + interrupt-parent = <&mpc5200_pic>;
> > + };
>
> And the same here.
'GPIO' is not a standard device type (at least there are no standard
set of GPIO bindings defined) so the device_type field should be
omitted. Compatible is sufficient.
Cheers,
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
[EMAIL PROTECTED]
(403) 399-0195
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
