On Oct 4, 2007, at 5:05 PM, Benjamin Herrenschmidt wrote: > >> From: Anton Vorontsov <[EMAIL PROTECTED]> >> Subject: [PATCH] [POWERPC] QEIC: Implement pluggable handlers, fix >> MPIC cascading >> >> set_irq_chained_handler overwrites MPIC's handle_irq function >> (handle_fasteoi_irq) thus MPIC never gets eoi event from the >> cascaded IRQ. This situation hangs MPIC on MPC8568E. >> >> To solve this problem efficiently, QEIC needs pluggable handlers, >> specific to the underlaying interrupt controller. >> >> Patch extends qe_ic_init() function to accept low and high interrupt >> handlers. To avoid #ifdefs, stack of interrupt handlers specified in >> the header file and functions are marked 'static inline', thus >> handlers are compiled-in only if actually used (in the board file). >> Another option would be to lookup for parent controller and >> automatically detect handlers, but this will waste text size because >> of never used handlers. >> >> qe_ic_init() also changed in regard to support multiplexed high/low >> lines as found in MPC8568E-MDS, plus qe_ic_cascade_muxed_mpic() >> handler implemented appropriately. >> >> Signed-off-by: Anton Vorontsov <[EMAIL PROTECTED]> > > Looks allright, if it also works, then ship it :-) > > Acked-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>
Now that this has been ack'd by Ben if you can respin the patch set we can get these in for 2.6.24 (I assume you are using a UCC as ethernet for test some of the QE support on 8568?) - k _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
