Hi Scott, A minor error handling bug
> + const u32 *data = of_get_property(np, "phy-handle", &len); > + if (!data || len != 4) > + return -EINVAL; > + > + phynode = of_find_node_by_phandle(*data); > + if (!phynode) > + return -EINVAL; > + > + mdionode = of_get_parent(phynode); > + if (!phynode) if (!mdionode) > + goto out_put_phy; Best regards, Esben _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev