On Fri, Sep 28, 2007 at 02:42:32PM -0600, Grant Likely wrote: > On 9/28/07, Olof Johansson <[EMAIL PROTECTED]> wrote: > > > Hmm, I see the start changed, and you're now reading/writing a full > > 32-bit word instead of individual bytes. Still, looks a little fishy to > > me. Wouldn't it be more appropriate to change the ULITE_RX offset to be > > 3 higher and still read/write bytes? > > > > Or are the registers defined as 32-bit ones? (I don't remember, it was > > so long since I touched uartlite myself. :-) > > All the registers are defined as 32 bit ones. I think it makes more > sense to access the registers as they are documented, and it > eliminates the 'magic' +3 needed to make it work now.
Ok, thaks for the clarification. Feel free to add it as motivation in the patch description. :) > > (Same for the other functions below, but the general principle applies.) > > > > Also, I'm not sure you need to cast port->membase to void*, do you? The > > math will still be right since it's declared as char *. > > membase is now defined as u32*, so the cast is needed. Hm, I must have looked at a stale tree. Thanks, -Olof _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
