On Wednesday 26 September 2007, Ishizaki Kou wrote:
> This patch is an update for "Beat on Celleb"
> - Move beat_pause(), beat_kexec_cpu_down() from setup.c to beat.c
>
> Signed-off-by: <[EMAIL PROTECTED]>
Acked-by: Arnd Bergmann <[EMAIL PROTECTED]>
The patch looks good, once you fix this one line:
> @@ -36,5 +36,9 @@ ssize_t beat_nvram_get_size(void);
> ssize_t beat_nvram_read(char *, size_t, loff_t *);
> ssize_t beat_nvram_write(char *, size_t, loff_t *);
> int beat_set_xdabr(unsigned long);
> +void beat_power_save(void);
> +#ifdef CONFIG_KEXEC
> +void beat_kexec_cpu_down(int, int);
> +#endif
Function declarations in headers files should not be enclosed in #ifdef,
it only causes unnecessary rebuilds when the configuration changes, but
does not help.
Arnd <><
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
