On Fri, Sep 14, 2007 at 03:48:54AM -0700, Andrew Morton wrote: > On Wed, 5 Sep 2007 09:27:43 -0500 Olof Johansson <[EMAIL PROTECTED]> wrote: > > > Convert the io_req_t members to kio_addr_t, to allow use on machines with > > more than 16 bits worth of IO port address space (ppc64 in this case, > > but it applies to others as well). > > drivers/usb/host/sl811_cs.c: In function 'sl811_cs_config': > drivers/usb/host/sl811_cs.c:263: warning: format '%04x' expects type > 'unsigned int', but argument 2 has type 'kio_addr_t' > drivers/usb/host/sl811_cs.c:263: warning: format '%04x' expects type > 'unsigned int', but argument 3 has type 'long unsigned int' > > That's not just a cosmetic thing - the printk can print junk and if there's > a %s in the control string after the %x's, printk() will crash. > > I don't know how many instances of this are in the tree, but they'll all > need to be found and fixed.
A crap, I completely forgot to check drivers/, and my default builds don't contain many of them. My bad. I'll do a full pass and review all references to the changed variables. So far I've only noticed printk stuff, but I'm not done. There's a fair amount lot of places where they're cast into ints instead of longs, but that's a whole other ball of wax (and shouldn't cause regressions like the printk ones could). -Olof _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
