On Wed, 29 Aug 2007 18:19:29 -0700 Pete/Piet Delaney wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Pete/Piet Delaney wrote: > > Jason Wessel wrote: > >> Andrew Morton wrote: > >>> On Wed, 22 Aug 2007 17:44:12 -0500 > >>> Jason Wessel <[EMAIL PROTECTED]> wrote: > >>> > >>> > >>>> + while (!atomic_read(&debugger_active)); > >>>> > >>> eek. We're in the process of hunting down and eliminating exactly this > >>> construct. There have been cases where the compiler cached the > >>> atomic_read() result in a register, turning the above into an infinite > >>> loop. > >>> > >>> Plus we should never add power-burners like that into the kernel > >>> anyway. That loop should have a cpu_relax() in it. Which will also > >>> fix the > >>> compiler problem described above. > >>> > >>> > >> Agreed, and fixed with a cpu_relax. > > > >>> Thirdly, please always add a newline when coding statements like that: > >>> > >>> while (expr()) > >>> ; > >>> > >> The other instances I found of the same problem in the kgdb core are > >> fixed too. > > > >> I merged all the changes into the for_mm branch in the kgdb git tree. > > > > Where is the kgdb git tree? > > Why am I getting this when I do: > > git clone > http://master.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb.git > > - > ---------------------------------------------------------------------------- > error: Couldn't get > http://master.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb.git/refs/tags/v2.6.11 > for tags/v2.6.11 > The requested URL returned error: 404 > error: Could not interpret tags/v2.6.11 as something to pull > rm: cannot remove directory > `/nethome/piet/Src/linux/git/jwessel/linux-2.6-kgdb/.git/clone-tmp': > Directory not empty > /nethome/piet/Src/linux/git/jwessel$ > - > ----------------------------------------------------------------------------
See the URLs at the top of http://git.kernel.org/?p=linux/kernel/git/jwessel/linux-2.6-kgdb.git;a=summary and try one of those (the git one preferably). > We are getting a problem with VMware where kernel text is the schedler > is getting wacked with four null bytes into the code. Thought I'd use > the current linux-2.6-kgdb.git tree and possible the CONFIG_DEBUG_RODATA > patch to make kernel text readonly: > > https://www.x86-64.org/pipermail/patches/2007-March/003666.html > > I thought the kernel text was RO and gdb had to disable it to > insert a breakpoint. > > - -piet > > > > > -piet > > > >> Thanks, > >> Jason. > >> - > >> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > >> the body of a message to [EMAIL PROTECTED] > >> More majordomo info at http://vger.kernel.org/majordomo-info.html > >> Please read the FAQ at http://www.tux.org/lkml/ > > > > > - - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v1.4.7 (GNU/Linux) > Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org > > iD8DBQFG1hshJICwm/rv3hoRAhTGAJ46pq69zYHqRmT+yTmRx+RVh8aBtgCfdyFM > gl91xCFTy0NJxHalVXpd9Os= > =c8FZ > -----END PGP SIGNATURE----- > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
