On Thu, 2007-08-16 at 01:03 +0300, Ilpo Järvinen wrote: > A similar fix to netfilter from Eric Dumazet inspired me to > look around a bit by using some grep/sed stuff as looking for > this kind of bugs seemed easy to automate. This is one of them > I found where it looks like this semicolon is not valid. > > Signed-off-by: Ilpo Järvinen <[EMAIL PROTECTED]> > --- > > ...Since I'm not familiar with these parts of the kernel, you might know > better than I do if this is stuff is valid... > > arch/powerpc/mm/hash_utils_64.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/powerpc/mm/hash_utils_64.c b/arch/powerpc/mm/hash_utils_64.c > index f178957..a47151e 100644 > --- a/arch/powerpc/mm/hash_utils_64.c > +++ b/arch/powerpc/mm/hash_utils_64.c > @@ -795,7 +795,7 @@ void hash_preload(struct mm_struct *mm, unsigned long ea, > > #ifdef CONFIG_PPC_MM_SLICES > /* We only prefault standard pages for now */ > - if (unlikely(get_slice_psize(mm, ea) != mm->context.user_psize)); > + if (unlikely(get_slice_psize(mm, ea) != mm->context.user_psize)) > return; > #endif
Er yeah that's bad. On kernels with MM_SLICES set we never prefault anything .. oops .. And testing confirms that's what's happening, with the semicolon gone we do prefault somethings. Thanks to the frickin compiler for warning us, not. This should probably go to stable for 22 IMHO. Nice catch Ilpo, perhaps someone should hack sparse to check for that sort of thing. cheers -- Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
