Segher Boessenkool wrote: >> It seems that some versions of firmware will report a device >> node status as the string "okay". As we are not expecting this >> string, the device node will be ignored by the EEH subsystem. >> Which means EEH will not be enabled. >> >> When EEH is not enabled, PCI errors will be converted into >> Machine Check exceptions, and we'll have a very unhappy system. > >> - if (status && strcmp(status, "ok") != 0) >> + if (status && strncmp(status, "ok", 2) != 0) >> return NULL; /* ignore devices with bad status */ > > Shouldn't you check for the two literal strings, instead of > only matching the common prefix? Seems safer.
What are the chances that the status string is "oklahoma" or "okeechobee" or "okinawa"? -- Matt Sealey <[EMAIL PROTECTED]> Genesi, Manager, Developer Relations _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
