Soohyung Cho wrote: >>+void fsl_sleep_device(struct fsl_sleep_platform_data *data) { >>+ if (clock_regs && data->sccr_mask) { >>+ unsigned long flags; >>+ u32 sccr; > > > Your && operation between clock_regs and sccr_mask seems to be a little bit > mistake, > cause type is different.
Hmm? It's logical AND, not binary. There's no need for the types to be the same. > (clock->regs->sccr && data->sccr_mask) looks fine. Except that that would be wrong. I'm checking to make sure that the registers were found, not anything about the contents of the register. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev