On Mon, Aug 06, 2007 at 03:00:12PM +1000, David Gibson wrote: > On Fri, Aug 03, 2007 at 11:09:10AM -0500, Josh Boyer wrote: > > Add a bootwrapper for the AMCC 440EP Bamboo Eval board. This also adds a > > common fixup_clock function for all 440EP(x) chips. > > Ok, you have a separate bamboo.c and treeboot-bamboo.c, like with > ebony. However here, therer's only one outermost wrapper - > treeboot-bamboo.c which means there's not really any point to this > separation.
Milton already mentioned this the first time I submitted the patch. > Do you know if there are Bamboo boards with old u-boot versions, or > some other bootloader which would make the separation worthwhile > later? Yes, there are. And yes, I plan on submitting the cuboot-bamboo.c wrapper just as soon as I get a chance to get my board switched back to u-boot. It's actually pretty trivial to keep both PIBS and u-boot on a bamboo board, since you can program u-boot into the flash from PIBS and flip some switches to boot from it. josh _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
