On Wed, Aug 01, 2007 at 07:01:17AM +0200, Segher Boessenkool wrote:
> >> + { /* 440EPX - without Security/Kasumi */
> >> + .pvr_mask = 0xf0000fff,
> >> + .pvr_value = 0x200008D4,
> >> + .cpu_name = "440EPX - no Security/Kasumi",
> >> + .cpu_features = CPU_FTRS_44X,
> >> + .cpu_user_features = COMMON_USER_BOOKE |
> >> PPC_FEATURE_HAS_FPU, /*
> >> 440EPX has an FPU */
> >> + .icache_bsize = 32,
> >> + .dcache_bsize = 32,
> >> + },
> >
> > Since the with/without Security/Kasumi versions have no differences in
> > their cputable entry other than the PVR, couldn't you just remove the
> > relevant PVR bit from the mask and use a single entry?
>
> And get rid of the stupid "has an FPU" comment at the same time
> please :-)
Actually that comment may be worthwhile if expanded a little. I think
the point is that 440EPx *unlike most other 4xx chips* has an FPU. So
the point of the comment is not explaining the feature bit, which is
obvious, but as a "no, really, it does".
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
