On Jul 20, 2007, at 3:15 AM, Ishizaki Kou wrote: > Milton Miller <[EMAIL PROTECTED]> wrote: >> On Jul 18, 2007, at 11:12 AM, Andreas Schwab wrote: >> >>> Milton Miller <[EMAIL PROTECTED]> writes: >>> >>>>> case '?': >>>>> - printf(help_string); >>>>> + xmon_puts(help_string); >>>>> break; >>>>> >>>> >>>> nonstdio.h #defines printf to xmon_printf. Please add a similar >>>> line >>>> for puts, and use the define here. (It will avoid an unnecessary >>>> difference with the user space version). >>> >>> User space puts add a newline, which this xmon_puts doesn't. >>> >>> Andreas. >> >> Good point. This should be xmon_fputs #defined to fputs. >> >> milton > > Should we change like below? > > define fputs: > #define fputs(str,stream) xmon_fputs(str) /* stream is ignored. */ > > show the help string: > fputs(help_string, stdout); >
Sounds good to me. It's consistent with using printf. milton _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
