Vitaly Bordug wrote: > On Tue, 17 Jul 2007 11:36:45 -0500 > Scott Wood <[EMAIL PROTECTED]> wrote: >>We should be removing this from board files that have it, not adding it >>to ones that don't. > > Yet many boards still have this stuff (like pretty recent 86xx) - should > we at least add some comments or clean that up?
See above. :-) AFAICT, it's just copied from board to board without thought. It should be removed. >>The ppc_md RTC functions should really just go away, though -- setting >>the clock on bootup can be done by generic code, and periodically >>updating the RTC when using NTP can be done from userspace. > > If those ppc_md hookups would be declared deprecated, there's no much sense > in the upper, > apparently. But I am not sure they will be... I'm inclined to let this patch > floating since > interacting with rtc class from within BSP code just does not worth it. I'm not sure they will either; I just wish they would be. :-) In the meantime, some sort of workqueue-based hookup to the RTC class API should be used. I believe there have been patches along those lines posted in the past. -Scott _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
