On Fri, 2007-07-13 at 12:02 -0700, Andrew Morton wrote: > On Fri, 13 Jul 2007 09:02:16 -0500 > Josh Boyer <[EMAIL PROTECTED]> wrote: > > > This is a resend of a patch David sent out on May 7. Without it, the > > PowerPC 44x port in 2.6.22 and on is broken. I've rebased it off of > > Linus' current tree. Please consider pushing this soon. > > > > josh > > > > > > At present, various parts of the serial code use unsigned long to > > define resource addresses. This is a problem, because some 32-bit > > platforms have physical addresses larger than 32-bits, and have mmio > > serial uarts located above the 4GB point. > > > > This patch changes the type of mapbase in both struct uart_port and > > struct plat_serial8250_port to resource_size_t, which can be > > configured to be 64 bits on such platforms. The mapbase in > > serial_struct can't safely be changed, because that structure is user > > visible. > > This is something we should do, but I have recollections of Russell > identifying problems with this patch, or at least an earlier version of it?
I can't recall myself if there were problems or not. I thought David had worked that out with Russell, but I could be mistaken. > > Signed-off-by: David Gibson <[EMAIL PROTECTED]> > > This should have had Signed-off-by:you as well. Oops, for the rebase I suppose, yes. Is the one below enough or do you want me to resubmit? Signed-off-by: Josh Boyer <[EMAIL PROTECTED]> josh _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
