On 2019/10/8 22:24, Kalle Valo wrote: > (PLEASE don't top post, fixing that manually) > > "zhengbin (A)" <[email protected]> writes: > >> On 2019/10/4 17:18, zhengbin wrote: >>> Fixes gcc '-Wunused-but-set-variable' warning: >>> >>> drivers/net/wireless/realtek/rtw88/rtw8822c.c: In function >>> rtw8822c_dpk_dc_corr_check: >>> drivers/net/wireless/realtek/rtw88/rtw8822c.c:2166:5: warning: variable >>> corr_val set but not used [-Wunused-but-set-variable] >>> >>> It is not used since commit 5227c2ee453d ("rtw88: >>> 8822c: add SW DPK support") >>> >>> Reported-by: Hulk Robot <[email protected]> >>> Signed-off-by: zhengbin <[email protected]> >> Sorry for the noise, please ignore this > Why? What was wrong in the patch?
I am not sure whether we can just remove corr_val = (u8)rtw_read32_mask(rtwdev, REG_STAT_RPT, GENMASK(15, 8))? rtw_read32_mask rtw_read32 ops->read32 Thank you for your remind of do not top post. BTW: patchset 'net/rtlwifi: remove some unused variables' & patch 'rtlwifi: rtl8192ee: Remove set but not used variable 'err'' are acked-by Ping-Ke Shih, can you help deal with it? >
