On Thu, Oct 05, 2017 at 08:11:55AM -0700, Tony Lindgren wrote:
> * Johan Hovold <jo...@kernel.org> [171005 02:15]:
> > On Thu, Sep 07, 2017 at 03:37:46PM +0200, Johan Hovold wrote:
> > > These patches fix a couple of bugs introduced by the recent runtime-PM
> > > work (details in the individual commit messages).
> > >
> > > Note that the external abort was due to the irq work never being flushed
> > > on suspend, and that we may need similar fixes for the delayed reset and
> > > resume work which are likewise never cancelled on suspend.
> > >
> > > As I just mentioned in the v1 thread, there are a number of further
> > > issues with
> > > musb suspend (e.g. on BBB):
> > >
> > > 1. System suspend appears to break any active gadget (which then can be
> > > restarted manually).
> > >
> > > 2. The early_tx polling in musb_cppi41 lacks a timeout, something which
> > > can
> > > lead to the hrtimer rescheduling itself indefinitely if the fifo never
> > > empties (e.g. if a transfer is is initiated post suspend due to issue
> > > 1).
> > >
> > > See commit a655f481d83d ("usb: musb: musb_cppi41: handle pre-mature TX
> > > complete interrupt").
> > >
> > > 3. In host mode, if a device is disconnected while the system is
> > > suspended,
> > > this will keep the controller runtime active after resume as the
> > > session
> > > bit is always set.
> >
> > Bin and Tony, any comments to this series?
>
> Oops sorry I forgot to test these after two recent conferences. I just gave
> these a try and they both behave for me. Nice fixes, for both:
>
> Tested-by: Tony Lindgren <t...@atomide.com>
Great, thanks for testing!
Johan
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
