"udc->regs" is zero here.  We don't set it until a couple lines later.
The intent was to test "udc->virt_addr".

Fixes: 1b9f35adb0ff ("usb: gadget: udc: Add Synopsys UDC Platform driver")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

diff --git a/drivers/usb/gadget/udc/snps_udc_plat.c 
b/drivers/usb/gadget/udc/snps_udc_plat.c
index 2e11f19e07ae..b8d1280faafc 100644
--- a/drivers/usb/gadget/udc/snps_udc_plat.c
+++ b/drivers/usb/gadget/udc/snps_udc_plat.c
@@ -122,8 +122,8 @@ static int udc_plat_probe(struct platform_device *pdev)
 
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        udc->virt_addr = devm_ioremap_resource(dev, res);
-       if (IS_ERR(udc->regs))
-               return PTR_ERR(udc->regs);
+       if (IS_ERR(udc->virt_addr))
+               return PTR_ERR(udc->virt_addr);
 
        /* udc csr registers base */
        udc->csr = udc->virt_addr + UDC_CSR_ADDR;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to