> -----Original Message----- > From: Andy Shevchenko [mailto:[email protected]] > Sent: Monday, July 10, 2017 3:57 PM > To: Limonciello, Mario <[email protected]> > Cc: Mathias Nyman <[email protected]>; USB <linux- > [email protected]>; [email protected]; [email protected]; > Greg Kroah-Hartman <[email protected]>; Felipe Balbi > <[email protected]>; [email protected]; > [email protected]; Wang, Keith <[email protected]>; > [email protected]; [email protected]; > [email protected]; [email protected] > Subject: Re: [PATCH v5] xhci: Bad Ethernet performance plugged in ASM1042A > host > > On Mon, Jul 10, 2017 at 11:38 PM, <[email protected]> wrote: > >> -----Original Message----- > >> From: Jiahau Chang [mailto:[email protected]] > >> Sent: Thursday, July 6, 2017 8:58 PM > >> To: Mathias Nyman <[email protected]> > >> Cc: [email protected]; [email protected]; > >> [email protected]; [email protected]; > >> [email protected]; [email protected]; Limonciello, Mario > >> <[email protected]>; [email protected]; Wang, > Keith > >> <[email protected]>; [email protected]; Jiahau Chang > >> <[email protected]>; Ian Pilcher <[email protected]> > >> Subject: Re: [PATCH v5] xhci: Bad Ethernet performance plugged in ASM1042A > host > >> > >> 2017-06-28 21:42 GMT+08:00 Mathias Nyman > <[email protected]>: > >> > On 22.06.2017 07:49, Jiahau Chang wrote: > >> >> > >> >> When USB Ethernet is plugged in ASMEDIA ASM1042A xHCI host, bad > >> >> performance was manifesting in Web browser use (like download > >> >> large file such as ISO image). It is known limitation of > >> >> ASM1042A that is not compatible with driver scheduling, > >> >> As a workaround we can modify flow control handling of ASM1042A. > >> >> The register we modify is changes the behavior > >> >> > >> >> Signed-off-by: Jiahau Chang <[email protected]> > >> >> Signed-off-by: Ian Pilcher <[email protected]> > >> >> --- > >> > > >> > > >> > Thanks, looks good, but checkpatch complains about: > >> > > >> >> + usleep_range(50, 50); > >> > > >> > > >> > having same min and max value. > >> > Does usleep_range(40,60) work for you? or some other range? > >> > > >> It works to use usleep_range(40,60); > >> Thanks for help us to upstream the patch. > >> > >> > I can change that myself, no need to resend. > >> > > > > > Matthias, > > > > Can you still get this in for 4.13? > > He is on vacation for few weeks. > > Perhaps in rcX. > >
Thanks for the heads up, I wasn't aware since I didn't get back any OOO or anything like that. I hope this can make it into one of the rc's indeed then when he returns. Thanks
