Greg KH <gre...@linuxfoundation.org> writes:

> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -475,11 +475,11 @@ static void snoop_urb(struct usb_device
>  
>       if (userurb) {          /* Async */
>               if (when == SUBMIT)
> -                     dev_info(&udev->dev, "userurb %p, ep%d %s-%s, "
> +                     dev_info(&udev->dev, "userurb %pK, ep%d %s-%s, "
>                                       "length %u\n",
>                                       userurb, ep, t, d, length);
>               else
> -                     dev_info(&udev->dev, "userurb %p, ep%d %s-%s, "
> +                     dev_info(&udev->dev, "userurb %pK, ep%d %s-%s, "
>                                       "actual_length %u status %d\n",
>                                       userurb, ep, t, d, length,
>                                       timeout_or_status);


Why replace only a subset?  It does nothing for security and makes this
file confusingly inconsistent IMHO.

bjorn@miraculix:/usr/local/src/git/linux$ git grep '%p' 
drivers/usb/core/devio.c 
drivers/usb/core/devio.c:                       dev_info(&udev->dev, "userurb 
%p, ep%d %s-%s, "
drivers/usb/core/devio.c:                       dev_info(&udev->dev, "userurb 
%p, ep%d %s-%s, "
drivers/usb/core/devio.c:               snoop(&ps->dev->dev, "reap %p\n", 
as->userurb);
drivers/usb/core/devio.c:               snoop(&ps->dev->dev, "reap %p\n", 
as->userurb);
drivers/usb/core/devio.c:               snoop(&ps->dev->dev, "reap %p\n", 
as->userurb);
drivers/usb/core/devio.c:               snoop(&ps->dev->dev, "reap %p\n", 
as->userurb);
drivers/usb/core/devio.c:               snoop(&dev->dev, "%s: DISCARDURB %p\n", 
__func__, p);



Bjørn
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to