On Wed, Apr 05, 2017 at 11:46:06AM +0200, Krzysztof Opasiak wrote:
>
>
> On 04/04/2017 09:08 PM, Yuyang Du wrote:
> >Hi Krzysztof,
> >
> >On Tue, Apr 04, 2017 at 04:52:32PM +0200, Krzysztof Opasiak wrote:
> >>
> >>
> >>On 03/31/2017 02:28 AM, Yuyang Du wrote:
> >>>A new field ncontrollers is added to the vhci_driver structure.
> >>>And this field is stored by scanning the vhci_hcd* dirs in the
> >>>platform udev.
> >>>
> >>>Suggested-by: Krzysztof Opasiak <k.opas...@samsung.com>
> >>>Signed-off-by: Yuyang Du <yuyang...@intel.com>
> >>>---
> >>>tools/usb/usbip/libsrc/vhci_driver.c | 32 +++++++++++++++++++++++++++++++-
> >>>tools/usb/usbip/libsrc/vhci_driver.h | 1 +
> >>>2 files changed, 32 insertions(+), 1 deletion(-)
> >>>
> >>>diff --git a/tools/usb/usbip/libsrc/vhci_driver.c
> >>>b/tools/usb/usbip/libsrc/vhci_driver.c
> >>>index f659c14..ccecd47 100644
> >>>--- a/tools/usb/usbip/libsrc/vhci_driver.c
> >>>+++ b/tools/usb/usbip/libsrc/vhci_driver.c
> >>>@@ -7,6 +7,7 @@
> >>>#include <limits.h>
> >>>#include <netdb.h>
> >>>#include <libudev.h>
> >>>+#include <dirent.h>
> >>>#include "sysfs_utils.h"
> >>>
> >>>#undef PROGNAME
> >>>@@ -134,6 +135,33 @@ static int get_nports(void)
> >>> return (int)strtoul(attr_nports, NULL, 10);
> >>>}
> >>>
> >>>+static int vhci_hcd_filter(const struct dirent *dirent)
> >>>+{
> >>>+ return strcmp(dirent->d_name, "vhci_hcd") >= 0 ? 1: 0;
> >>
> >>The ? operator may be omitted here as according to doc we need to
> >>return nonzero not 1 exactly.
> >
> >No, it can't. strcmp() would return negative if not containing "vhci_hcd".
> >E.g.,
> >
> >strcmp("!@#", "vhci_hcd") ==> -1
> >strcmp("v", "vhci_hcd") ==> -1
>
> I meant, just to drop the ? itself but leave >= 0
>
> return strcmp(dirent->d_name, "vhci_hcd") >= 0;
Oh, that's doable :)
Send a Reviewed-by ?
Thanks,
Yuyang
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
