On Wed, Jan 25, 2017 at 06:22:54PM +0100, Johan Hovold wrote: > Do not report ASYNC_SKIP_TEST or ASYNC_AUTO_IRQ as being set in > TIOCGSERIAL handlers as these flags are not supported and do not really > make any sense for USB serial devices in the first place. > > Signed-off-by: Johan Hovold <jo...@kernel.org> > --- > drivers/usb/serial/io_edgeport.c | 1 - > drivers/usb/serial/io_ti.c | 1 - > drivers/usb/serial/mos7720.c | 1 - > drivers/usb/serial/mos7840.c | 1 - > drivers/usb/serial/opticon.c | 1 - > drivers/usb/serial/quatech2.c | 1 - > drivers/usb/serial/ssu100.c | 1 - > drivers/usb/serial/whiteheat.c | 1 - > 8 files changed, 8 deletions(-) > > diff --git a/drivers/usb/serial/io_edgeport.c > b/drivers/usb/serial/io_edgeport.c > index 8ab5f5b49ef3..92abf92e5669 100644 > --- a/drivers/usb/serial/io_edgeport.c > +++ b/drivers/usb/serial/io_edgeport.c > @@ -1572,7 +1572,6 @@ static int get_serial_info(struct edgeport_port > *edge_port, > tmp.line = edge_port->port->minor; > tmp.port = edge_port->port->port_number; > tmp.irq = 0; > - tmp.flags = ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ; > tmp.xmit_fifo_size = edge_port->maxTxCredits; > tmp.baud_base = 9600; > tmp.close_delay = 5*HZ; > diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c > index 9a0db2965fbb..ceaeebaa6f90 100644 > --- a/drivers/usb/serial/io_ti.c > +++ b/drivers/usb/serial/io_ti.c > @@ -2468,7 +2468,6 @@ static int get_serial_info(struct edgeport_port > *edge_port, > tmp.line = edge_port->port->minor; > tmp.port = edge_port->port->port_number; > tmp.irq = 0; > - tmp.flags = ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ; > tmp.xmit_fifo_size = edge_port->port->bulk_out_size; > tmp.baud_base = 9600; > tmp.close_delay = 5*HZ; > diff --git a/drivers/usb/serial/mos7720.c b/drivers/usb/serial/mos7720.c > index acf431e02699..f075121c6e32 100644 > --- a/drivers/usb/serial/mos7720.c > +++ b/drivers/usb/serial/mos7720.c > @@ -1851,7 +1851,6 @@ static int get_serial_info(struct moschip_port > *mos7720_port, > tmp.line = mos7720_port->port->minor; > tmp.port = mos7720_port->port->port_number; > tmp.irq = 0; > - tmp.flags = ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ; > tmp.xmit_fifo_size = NUM_URBS * URB_TRANSFER_BUFFER_SIZE; > tmp.baud_base = 9600; > tmp.close_delay = 5*HZ; > diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c > index 155006acf918..d1b92f582478 100644 > --- a/drivers/usb/serial/mos7840.c > +++ b/drivers/usb/serial/mos7840.c > @@ -1963,7 +1963,6 @@ static int mos7840_get_serial_info(struct moschip_port > *mos7840_port, > tmp.line = mos7840_port->port->minor; > tmp.port = mos7840_port->port->port_number; > tmp.irq = 0; > - tmp.flags = ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ; > tmp.xmit_fifo_size = NUM_URBS * URB_TRANSFER_BUFFER_SIZE; > tmp.baud_base = 9600; > tmp.close_delay = 5 * HZ; > diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/opticon.c > index b3c64f557d60..3937b9c3cc69 100644 > --- a/drivers/usb/serial/opticon.c > +++ b/drivers/usb/serial/opticon.c > @@ -343,7 +343,6 @@ static int get_serial_info(struct usb_serial_port *port, > tmp.line = port->minor; > tmp.port = 0; > tmp.irq = 0; > - tmp.flags = ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ; > tmp.xmit_fifo_size = 1024; > tmp.baud_base = 9600; > tmp.close_delay = 5*HZ; > diff --git a/drivers/usb/serial/quatech2.c b/drivers/usb/serial/quatech2.c > index cf29128327d3..fdbb904d153f 100644 > --- a/drivers/usb/serial/quatech2.c > +++ b/drivers/usb/serial/quatech2.c > @@ -465,7 +465,6 @@ static int get_serial_info(struct usb_serial_port *port, > tmp.line = port->minor; > tmp.port = 0; > tmp.irq = 0; > - tmp.flags = ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ; > tmp.xmit_fifo_size = port->bulk_out_size; > tmp.baud_base = 9600; > tmp.close_delay = 5*HZ; > diff --git a/drivers/usb/serial/ssu100.c b/drivers/usb/serial/ssu100.c > index 55814538ff1f..5aa7bbbeba3d 100644 > --- a/drivers/usb/serial/ssu100.c > +++ b/drivers/usb/serial/ssu100.c > @@ -339,7 +339,6 @@ static int get_serial_info(struct usb_serial_port *port, > tmp.line = port->minor; > tmp.port = 0; > tmp.irq = 0; > - tmp.flags = ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ; > tmp.xmit_fifo_size = port->bulk_out_size; > tmp.baud_base = 9600; > tmp.close_delay = 5*HZ; > diff --git a/drivers/usb/serial/whiteheat.c b/drivers/usb/serial/whiteheat.c > index d3ea90bef84d..5ab65eb1dacc 100644 > --- a/drivers/usb/serial/whiteheat.c > +++ b/drivers/usb/serial/whiteheat.c > @@ -487,7 +487,6 @@ static int whiteheat_ioctl(struct tty_struct *tty, > serstruct.type = PORT_16654; > serstruct.line = port->minor; > serstruct.port = port->port_number; > - serstruct.flags = ASYNC_SKIP_TEST | ASYNC_AUTO_IRQ; > serstruct.xmit_fifo_size = kfifo_size(&port->write_fifo); > serstruct.custom_divisor = 0; > serstruct.baud_base = 460800;
This is probably my fault from back in 1999 or so, sorry about that... Reviewed-by: Greg Kroah-Hartman <gre...@linuxfoundation.org> -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
