From: Nicholas Mc Guire <hof...@osadl.org>

ulseep_range() uses hrtimers and provides no advantage over msleep()
for larger delays. Fix up the 20+ ms delays here passing the adjusted "min"
value to msleep(). This helps reduce the load on the hrtimer subsystem.

[johnyoun: minor rebase]
Signed-off-by: Nicholas Mc Guire <hof...@osadl.org>
Signed-off-by: John Youn <johny...@synopsys.com>
---
 drivers/usb/dwc2/hcd.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/drivers/usb/dwc2/hcd.c b/drivers/usb/dwc2/hcd.c
index de24c3e8f5c7..6d399485501f 100644
--- a/drivers/usb/dwc2/hcd.c
+++ b/drivers/usb/dwc2/hcd.c
@@ -2152,7 +2152,7 @@ static int dwc2_hcd_endpoint_disable(struct dwc2_hsotg 
*hsotg,
                }
 
                spin_unlock_irqrestore(&hsotg->lock, flags);
-               usleep_range(20000, 40000);
+               msleep(20);
                spin_lock_irqsave(&hsotg->lock, flags);
                qh = ep->hcpriv;
                if (!qh) {
@@ -3243,7 +3243,7 @@ static void dwc2_conn_id_status_change(struct work_struct 
*work)
                                 "Waiting for Peripheral Mode, Mode=%s\n",
                                 dwc2_is_host_mode(hsotg) ? "Host" :
                                 "Peripheral");
-                       usleep_range(20000, 40000);
+                       msleep(20);
                        /*
                         * Sometimes the initial GOTGCTRL read is wrong, so
                         * check it again and jump to host mode if that was
@@ -3273,7 +3273,7 @@ static void dwc2_conn_id_status_change(struct work_struct 
*work)
                        dev_info(hsotg->dev, "Waiting for Host Mode, Mode=%s\n",
                                 dwc2_is_host_mode(hsotg) ?
                                 "Host" : "Peripheral");
-                       usleep_range(20000, 40000);
+                       msleep(20);
                        if (++count > 250)
                                break;
                }
@@ -3366,7 +3366,7 @@ static void dwc2_port_suspend(struct dwc2_hsotg *hsotg, 
u16 windex)
 
                spin_unlock_irqrestore(&hsotg->lock, flags);
 
-               usleep_range(200000, 250000);
+               msleep(200);
        } else {
                spin_unlock_irqrestore(&hsotg->lock, flags);
        }
@@ -3390,7 +3390,7 @@ static void dwc2_port_resume(struct dwc2_hsotg *hsotg)
                pcgctl &= ~PCGCTL_STOPPCLK;
                dwc2_writel(pcgctl, hsotg->regs + PCGCTL);
                spin_unlock_irqrestore(&hsotg->lock, flags);
-               usleep_range(20000, 40000);
+               msleep(20);
                spin_lock_irqsave(&hsotg->lock, flags);
        }
 
@@ -3703,7 +3703,7 @@ static int dwc2_hcd_hub_control(struct dwc2_hsotg *hsotg, 
u16 typereq,
                        }
 
                        /* Clear reset bit in 10ms (FS/LS) or 50ms (HS) */
-                       usleep_range(50000, 70000);
+                       msleep(50);
                        hprt0 &= ~HPRT0_RST;
                        dwc2_writel(hprt0, hsotg->regs + HPRT0);
                        hsotg->lx_state = DWC2_L0; /* Now back to On state */
-- 
2.11.0

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to