>From: Peter Chen [mailto:hzpeterc...@gmail.com] >On Fri, Nov 11, 2016 at 09:31:09PM +0100, Arnd Bergmann wrote: >> On Thursday, November 10, 2016 1:02:11 PM CET Felipe Balbi wrote: >> > > @@ -123,8 +119,8 @@ int dwc3_host_init(struct dwc3 *dwc) void >> > > dwc3_host_exit(struct dwc3 *dwc) { >> > > phy_remove_lookup(dwc->usb2_generic_phy, "usb2-phy", >> > > - dev_name(&dwc->xhci->dev)); >> > > + dev_name(dwc->dev)); >> > > phy_remove_lookup(dwc->usb3_generic_phy, "usb3-phy", >> > > - dev_name(&dwc->xhci->dev)); >> > > + dev_name(dwc->dev)); >> > >> > this looks unrelated to $subject. Care to explain? >> >> bus->sysdev is used for retrieving any information that comes from >> the platform (DT or otherwise), and the phy lookup in has to be done >> through sysdev as well because the platform cannot add it to the child >> device it has no knowledge of. >> >> When we set the sysdev to the parent, the phy lookup has to be added >> to that device as well, rather than the child device. >> > >Then, the device should change to dwc->sysdev, and phy_create_lookup in this >file >needs to change too. >
Yes Peter. I agree to that. >-- > >Best Regards, >Peter Chen -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
