Hello,

Excuse me for disturbing, could I have a feedback?

On 20.05.2016 12:37, Alexander Popov wrote:
> stub_disconnect() calls stub_device_reset() during usb_unbind_device() when
> usb device is locked. So usb_lock_device_for_reset() in stub_device_reset()
> in that case polls for one second and returns -EBUSY anyway.
> 
> Remove useless flag USBIP_EH_RESET from SDEV_EVENT_REMOVED.
> 
> Signed-off-by: Alexander Popov <alpo...@ptsecurity.com>
> ---
>  drivers/usb/usbip/usbip_common.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/usbip/usbip_common.h 
> b/drivers/usb/usbip/usbip_common.h
> index 86b0847..c4b4938 100644
> --- a/drivers/usb/usbip/usbip_common.h
> +++ b/drivers/usb/usbip/usbip_common.h
> @@ -242,7 +242,7 @@ enum usbip_side {
>  #define USBIP_EH_RESET               (1 << 2)
>  #define USBIP_EH_UNUSABLE    (1 << 3)
>  
> -#define SDEV_EVENT_REMOVED   (USBIP_EH_SHUTDOWN | USBIP_EH_RESET | 
> USBIP_EH_BYE)
> +#define      SDEV_EVENT_REMOVED      (USBIP_EH_SHUTDOWN | USBIP_EH_BYE)
>  #define      SDEV_EVENT_DOWN         (USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
>  #define      SDEV_EVENT_ERROR_TCP    (USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
>  #define      SDEV_EVENT_ERROR_SUBMIT (USBIP_EH_SHUTDOWN | USBIP_EH_RESET)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to