Hi, Jun Li <jun...@nxp.com> writes: >> -----Original Message----- >> From: Baolin Wang [mailto:baolin.w...@linaro.org] >> Sent: Wednesday, March 30, 2016 5:31 PM >> To: Jun Li <jun...@nxp.com> >> Cc: Peter Chen <hzpeterc...@gmail.com>; Felipe Balbi <ba...@kernel.org>; >> Greg KH <gre...@linuxfoundation.org>; Sebastian Reichel <s...@kernel.org>; >> Dmitry Eremin-Solenikov <dbarysh...@gmail.com>; David Woodhouse >> <dw...@infradead.org>; Peter Chen <peter.c...@freescale.com>; Alan Stern >> <st...@rowland.harvard.edu>; r.bald...@samsung.com; Yoshihiro Shimoda >> <yoshihiro.shimoda...@renesas.com>; Lee Jones <lee.jo...@linaro.org>; Mark >> Brown <broo...@kernel.org>; Charles Keepax >> <ckee...@opensource.wolfsonmicro.com>; patc...@opensource.wolfsonmicro.com; >> Linux PM list <linux...@vger.kernel.org>; USB <linux-usb@vger.kernel.org>; >> device-mainlin...@lists.linuxfoundation.org; LKML <linux- >> ker...@vger.kernel.org> >> Subject: Re: [PATCH v8 0/4] Introduce usb charger framework to deal with >> the usb gadget power negotation >> >> On 30 March 2016 at 16:07, Jun Li <jun...@nxp.com> wrote: >> > Hi >> >> >> On 30 March 2016 at 10:54, Jun Li <jun...@nxp.com> wrote: >> >> >> >> It is not for udc driver but for power users who want to >> >> >> >> negotiate with USB subsystem. >> >> >> >> >> >> >> > >> >> >> > Seems you don't want to guarantee charger type detection is done >> >> >> > before gadget connection(pullup DP), right? >> >> >> > I see you call usb_charger_detect_type() in each gadget usb >> >> >> > state >> >> >> changes. >> >> >> >> >> >> I am not sure I get your point correctly, please correct me if I >> >> >> misunderstand you. >> >> >> We need to check the charger type at every event comes from the >> >> >> usb gadget state changes or the extcon device state changes, which >> >> >> means a new charger plugin or pullup. >> >> >> >> >> > >> >> > According to usb charger spec, my understanding is you can't do >> >> > real charger detection procedure *after* gadget _connection_(pullup >> >> > DP), also I don't >> >> >> >> Why can not? Charger detection is usually from PMIC. >> > >> > Charger detection process will impact DP/DM line state, see usb >> > charger spec v1.2 for detail detection process, section 4.6.3 says: >> > >> > "A PD is allowed to *disconnect* and repeat the charger detection >> > process multiple times while attached. The PD is required to wait for >> > a time of at least TCP_VDM_EN max between disconnecting and restarting >> > the charger detection process." >> > >> > As Peter mentioned, the charger detection should happen between VBUS >> > detection and gadget pull up DP for first plug in case. So when&after >> > gadget connect (pullup DP), you should already know the charger type. >> >> Make sense. In our company's solution, charger detection can be done by >> hardware from PMIC at first, then it will not affect the DP/DM line when >> gadget starts to enumeration. > > I see, charger type detection is done automatically by PMIC when VBUS > is detected in your case, you just assume the process is complete
assuming this finishes before gadget starts is a bad idea. It would've been much more robust to delay usb_gadget_connect() until we KNOW charger detection has completed. -- balbi
signature.asc
Description: PGP signature
