Hi, "Felipe F. Tonello" <e...@felipetonello.com> writes: > [ text/plain ] > buflen by default (256) is smaller than wMaxPacketSize (512) in high-speed > devices. > > That caused the OUT endpoint to freeze if the host send any data packet of > length greater than 256 bytes. > > This is an example dump of what happended on that enpoint: > HOST: [DATA][Length=260][...] > DEVICE: [NAK] > HOST: [PING] > DEVICE: [NAK] > HOST: [PING] > DEVICE: [NAK] > ... > HOST: [PING] > DEVICE: [NAK] > > Users should not change the buffer size to anything other than wMaxPacketSize > because that can cause bugs (this bug) or performance issues. Thus, this patch > fixes this problem by eliminating buflen entirely and replacing it with > wMaxPacketSize of the appropriate endpoint where needed. > > Signed-off-by: Felipe F. Tonello <e...@felipetonello.com> > --- > > v2: > - Removed buflen
sounds like removing buflen should be delyed to v4.7 merge window while the fix is, indeed, needed. Can you drop the removal of buflen ? I guess it's mostly about picking v1 and fixing endianess problems ? -- balbi
signature.asc
Description: PGP signature
