On Fri, Dec 25, 2015 at 01:36:44PM -0500, Alan Stern wrote: > That's okay; lots of drivers do this and people expect it. It also > reduces the total amount of code.
Okay, fixed. > > > > + mem = usb_alloc_coherent(ps->dev, size, GFP_KERNEL, > > > > &dma_handle); > > > Shouldn't this be GFP_USER to let limits apply? > > This I don't really know anything about. Alan? > There doesn't appear to be very much difference between them. As far > as I can tell from the documentation in include/linux/gfp.h, GPF_USER > would indeed be more appropriate. OK, changed this one to GFP_USER, but kept all the others at GFP_KERNEL since it seemed the most consistent with the other code. /* Steinar */ -- Software Engineer, Google Switzerland -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
