On Wed, 30 Sep 2015, Luis de Bethencourt wrote: > The driver is using -1 instead of the -ENOMEM defined macro to specify > that a buffer allocation failed. Since the error number is propagated, > the caller will get a -EPERM which is the wrong error condition.
Generally I agree that the more specific errno, the better. But I am not really sure where you are seeing the bug (mapping to -EPERM) in this case? I think the only caller of hiddev_connect() should be hid_connect(), and the only thing that guy cares about whether individual callbacks succeed or fail, so that it sets hdev->clamed flags accordingly. Could you please be more specific about the -EPERM mapping you are talking about? Thanks, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
