Alexandre Courbot <acour...@nvidia.com> writes: > On 03/28/2015 04:30 AM, Uwe Kleine-König wrote: > Looks good, but can't we also merge the call to gpiod_direction to avoid using > GPIOD_ASIS? The golden rule is that a direction should not remain in an > unknown > state after being requested. > > This would also require adding a flag to the alternative calls to > gpio_request_one(). At first sight it seems to be doable, but I don't know > these > drivers well enough to have an informed opinion. Is the following information enough to grant the "doable" ? : - gpiod_reset is always an output gpio - gpiod_vbus is aslways an input gpio
Moreover, I seem to remember there was a bit of back and forth around the reset gpio, so there's something subtle I don't remember (Fabio maybe your memory is better than mine here) ... Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html