Hello Sebastian Andrzej Siewior,
The patch c52661d60f63: "usb-gadget: Initial merge of target module
for UASP + BOT" from May 3, 2012, leads to the following static
checker warning:
drivers/usb/gadget/legacy/tcm_usb_gadget.c:1155 usbg_submit_command()
warn: bool is not less than zero.
drivers/usb/gadget/legacy/tcm_usb_gadget.c
1153 INIT_WORK(&cmd->work, usbg_cmd_work);
1154 ret = queue_work(tpg->workqueue, &cmd->work);
^^^^^^^^^^^
This is a bool type. Presumably we can remove the "if (ret < 0)" check?
1155 if (ret < 0)
1156 goto err;
1157
1158 return 0;
1159 err:
1160 kfree(cmd);
1161 return -EINVAL;
1162 }
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html
