On Thu, Jan 29, 2015 at 8:41 PM, Robert Jarzmik <robert.jarz...@free.fr> wrote:
> +       if (nop->gpiod_reset)
> +               gpiod_direction_output(nop->gpiod_reset, 0);

Why do you set it to zero independently of the GPIO active level flag?

Previously, we had:

        if (nop->reset_active_low)
            gpio_flags = GPIOF_OUT_INIT_LOW;
        else
            gpio_flags = GPIOF_OUT_INIT_HIGH;

        err = devm_gpio_request_one(dev, nop->gpio_reset,
                        gpio_flags, dev_name(dev));

,which correctly puts the GPIO output to the correct initial level
depending on the active level flag.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to