Hi Andrzej, On Sunday 07 December 2014 23:09:42 Laurent Pinchart wrote: > On Friday 05 December 2014 15:16:35 Andrzej Pietrasiewicz wrote: > > If the caller of uvc_alloc() does not provide enough > > descriptors, binding the function should fail, so appropriate > > code is returned from uvc_copy_descriptors(). > > > > uvc_function_bind() is modified accordingly to account for possible > > errors from uvc_copy_descriptors(). > > > > Signed-off-by: Andrzej Pietrasiewicz <andrze...@samsung.com> > > --- > > > > drivers/usb/gadget/function/f_uvc.c | 23 +++++++++++++++++++++-- > > 1 file changed, 21 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/usb/gadget/function/f_uvc.c > > b/drivers/usb/gadget/function/f_uvc.c index 5b4ab39..b14c599 100644 > > --- a/drivers/usb/gadget/function/f_uvc.c > > +++ b/drivers/usb/gadget/function/f_uvc.c > > @@ -508,6 +508,8 @@ uvc_copy_descriptors(struct uvc_device *uvc, enum > > usb_device_speed speed) uvc_streaming_std = uvc_fs_streaming; > > break; > > } > > Nitpicking, could you please insert a blank line here ?
I just noticed that the blank line is in patch 3/3. Just move it to 2/3 and everything will be fine :-) > With this changed, > > Acked-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com> > > > + if (!uvc_control_desc || !uvc_streaming_cls) > > + return ERR_PTR(-ENODEV); > > > > /* Descriptors layout > > * -- Regards, Laurent Pinchart -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
