usb_stor_euscsi_init() enables multi-target mode for SCM eUSB SCSI bridge
devices. The control message it sends has wLength = 1 and the byte sent is
0x01. While that works, the SCM Windows driver does it with wLength = 0. We
may as well match what the SCM driver does.

Signed-off-by: Mark Knibbs <ma...@clara.co.uk>

---

v4: Patch rebased on usb-linus branch of gregkh usb.git (latest commit
1910195423e7bea4c01c42bfe3f81792a6e969bb)
v3: Add spaces, 5*HZ --> 5 * HZ
v2: Remove incorrect use of USB_CTRL_SET_TIMEOUT (=5000);
usb_stor_control_msg() timeout argument is actually specified in jiffies.

diff --git a/drivers/usb/storage/initializers.c 
b/drivers/usb/storage/initializers.c
index 73f125e..31fa2e9 100644
--- a/drivers/usb/storage/initializers.c
+++ b/drivers/usb/storage/initializers.c
@@ -49,10 +49,9 @@ int usb_stor_euscsi_init(struct us_data *us)
        int result;
 
        usb_stor_dbg(us, "Attempting to init eUSCSI bridge...\n");
-       us->iobuf[0] = 0x1;
        result = usb_stor_control_msg(us, us->send_ctrl_pipe,
                        0x0C, USB_RECIP_INTERFACE | USB_TYPE_VENDOR,
-                       0x01, 0x0, us->iobuf, 0x1, 5 * HZ);
+                       0x01, 0x0, NULL, 0x0, 5 * HZ);
        usb_stor_dbg(us, "-- result is %d\n", result);
 
        return 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to